Lock and release as tightly around contented entity as possible

This is part of the Semicolon&Sons Code Diary - consisting of lessons learned on the job. You're in the algorithms category.

Last Updated: 2021-05-15

I had the following code for sending out emails in a background queue. Unfortunately, due to a temporary network outage causing http requests to our geocoder to fail, the job remained locked and could not be retried.

Here was the code:


if ($this->reverseAuctionRequest->isLocked()) {
    Log::info('Ignoring what seems like a duplicate ReverseAuctionRequest job');

// This helps us prevent the situation where we process
// something multiple times by access and send out too many emails.
$advisors = $this->chooseAdvisors(10);

private function chooseAdvisors($numberToContact) : iterable
    $geocodeResults = Http::getGeocood($address);
    ... // Happy path not depicted
    if (! is_null($geocodeResults["latitude"])) {
      throw new \Exception("Could not calculate geocords.");

The issue was that I did not release the lock when an exception with the geocoder occurred. One solution would be to release in a catch statement, no matter what. Another would be to do the idempotent querying first to grab the advisors first (triggering the possible geocoding exception earlier) and then locking at last possible moment.

<? php
    $advisors = $this->chooseAdvisors(10);
    // moved down until after the non-mutating querying